Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wxGUI Layer Manager close the Layers NoteBook Display FlatNotebook page #411

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Fix wxGUI Layer Manager close the Layers NoteBook Display FlatNotebook page #411

merged 1 commit into from
Mar 16, 2020

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Mar 13, 2020

Reproduce:

  1. On the Layer Manager -> Layers NoteBook page -> Display 1 FlatNotebook page, click on the close page x button.

layers_display_page

Error message appear in the Console page:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-
packages/wx/lib/agw/flatnotebook.py", line 5475, in OnLeftUp

self.DeletePage(self._iActivePage)
  File "/usr/lib/python3/dist-
packages/wx/lib/agw/flatnotebook.py", line 5665, in
DeletePage

book.DeletePage(page)
  File "/usr/lib/python3/dist-
packages/wx/lib/agw/flatnotebook.py", line 4473, in
DeletePage

pageRemoved.Destroy()
wx._core
.
wxAssertionError
:
C++ assertion "GetEventHandler() == this" failed at
../src/common/wincmn.cpp(478) in ~wxWindowBase(): any pushed
event handlers must have been removed

@landam landam added this to the 7.8.3 milestone Mar 13, 2020
@landam landam added the bug Something isn't working label Mar 13, 2020
@tmszi tmszi mentioned this pull request Mar 15, 2020
Merged
@landam landam merged commit 5b4722a into OSGeo:master Mar 16, 2020
landam pushed a commit that referenced this pull request Mar 16, 2020
@tmszi @landam
wxGUI Layer Manager: fix close Layers Display FlatNotebook page (#411)
c32e169
tmszi added a commit to tmszi/grass that referenced this pull request Mar 18, 2020
@tmszi
wxGUI Map Display Window: fix close frame
aad2a7b 
* fix PR (OSGeo#411)
@tmszi tmszi mentioned this pull request Mar 18, 2020
Closed
HuidaeCho pushed a commit to HuidaeCho/grass that referenced this pull request Mar 20, 2020
@tmszi @HuidaeCho
wxGUI Layer Manager: fix close Layers Display FlatNotebook page (OSGe…
d1dd91d 
…o#411)
@tmszi tmszi deleted the fix_close_layers_display_flatnotebook_page branch July 28, 2020 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@landam landam landam approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
7.8.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tmszi @landam