Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use wxGUI Raster Digitizer input raster map layer temporary region #470

Merged

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Mar 31, 2020

To reproduce:

  1. Create backup of the some raster map layer (g.copy) which you use in this test
  2. On The Layer Manager add some raster map layer (which you copied in the first step)
  3. Set computational region outside of the raster map layer (raster map layer added in the second step)
  4. Zoom to raster map layer (raster map layer added in the second step).
  5. On the Map display windows toolbar combobox widget choose Raster digitizer (start digitzing)
  6. On the Raster digitizer toolbar choose Digitize point (add some points)
  7. After digitization click on the Quit raster digitizer toolbar icon, and on the next confirm dialog click on the Yes button (save changes).
  8. Result edited raster map layer consist null values only (check the raster map layer metadata with r.info)

Default behavior:

rdigit

Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use_temp_region is not meant to be used in GUI, with this, the entire GUI is using the temporary region. The environment with GRASS_REGION variable needs to be passed to the rdigit's run_commands, similarly as in RenderMapMgr.GetRenderEnv() in core/render.py

@tmszi tmszi force-pushed the fix_rdigit_use_input_raster_map_region branch from 89e5a9c to 161036e Compare April 7, 2020 05:02
@tmszi tmszi force-pushed the fix_rdigit_use_input_raster_map_region branch from 161036e to 25d8891 Compare April 7, 2020 11:47
@tmszi
Copy link
Member Author

tmszi commented Apr 7, 2020

Hello, alright thank you very much for explanation.

@petrasovaa petrasovaa merged commit d48aa48 into OSGeo:master Apr 7, 2020
@petrasovaa
Copy link
Contributor

Thank you for quickly addressing this!

@tmszi tmszi deleted the fix_rdigit_use_input_raster_map_region branch July 28, 2020 07:14
@neteler neteler added this to the 8.0.0 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants