Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v.db.addtable: Overwrite newly created cat column (Fix #567) #571

Merged
merged 2 commits into from
May 2, 2020

Conversation

HuidaeCho
Copy link
Member

@HuidaeCho HuidaeCho commented Apr 29, 2020

This PR adds the overwrite flag to v.to.db (Fix #567).

@HuidaeCho HuidaeCho changed the title Fix #567 v.db.addtable: Overwrite newly created cat column (Fix #567) Apr 29, 2020
@HuidaeCho HuidaeCho added the bug Something isn't working label Apr 30, 2020
@HuidaeCho HuidaeCho added this to the 7.8.4 milestone Apr 30, 2020
@metzm
Copy link
Contributor

metzm commented May 2, 2020

Looks good to me. Please merge and backport to G78.

@HuidaeCho HuidaeCho merged commit 9bf0ae9 into OSGeo:master May 2, 2020
@HuidaeCho HuidaeCho deleted the v_db_addtable_cat_error branch May 2, 2020 22:32
HuidaeCho added a commit that referenced this pull request May 2, 2020
* Fix #567

* v.to.lines: v.to.db creates left and right columns
@HuidaeCho
Copy link
Member Author

Merged to master; Backported to 7.8

@neteler
Copy link
Member

neteler commented May 2, 2020

Does this backported interfere with the ongoing release? Do we need RC3 now?

@HuidaeCho
Copy link
Member Author

Does this backported interfere with the ongoing release? Do we need RC3 now?

I don't think so.

@ninsbl
Copy link
Member

ninsbl commented May 3, 2020

Does this backported interfere with the ongoing release? Do we need RC3 now?

Are we supposed to pause backporting other stuff after a RC is tagged and limit backports to issues discovered in the RC? Even backports can introduce new issues... So, would be the policy be to wait for next point release?

Just asking, cause I have other stuff that cold be backported.

@neteler
Copy link
Member

neteler commented May 3, 2020

Yes, please wait with backports till 7.8.3 is out (in the next days). Otherwise we need RC after RC...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] v.db.addtable complains about existing cat-column when creating a new table
4 participants