Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxGUI r.li.setup: Show message dialog if removed config file isn't selected from the list #631

Merged
merged 2 commits into from May 15, 2020
Merged

wxGUI r.li.setup: Show message dialog if removed config file isn't selected from the list #631

merged 2 commits into from May 15, 2020

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented May 13, 2020

To reproduce:

  1. On Layer Manager Window go to menu Raster -> Landscape patch analysis -> Set up sampling and analysis framework (or run g.gui.rlisetup), open rlisetup dialog
  2. Don't select config file from the list (or don't have created any config file -> empty list)
  3. Click on the Remove button

Error message (Console page):

Traceback (most recent call last):
  File "/usr/lib64/grass79/gui/wxpython/rlisetup/frame.py",
line 221, in OnRemove

confile =
self.listfiles[self.listfileBox.GetSelections()[0]]
IndexError
:
list index out of range

@tmszi tmszi force-pushed the fix_rlisetup_dialog_remove_btn branch from 41aa3ed to b41eb83 Compare May 13, 2020 09:20
petrasovaa
petrasovaa requested changes May 14, 2020
View reviewed changes
gui/wxpython/rlisetup/frame.py Outdated Show resolved Hide resolved
@petrasovaa petrasovaa merged commit b243fbe into OSGeo:master May 15, 2020
petrasovaa pushed a commit that referenced this pull request May 15, 2020
@tmszi @petrasovaa
wxGUI r.li.setup: Show message dialog if removed config file isn't se…
bbe3d3e 
…lected from the list (#631)

* wxGUI g.gui.rlisetup: show message dialog if removed config file isn't selected from the list

* wxGUI g.gui.rlisetup: specify exception type
@petrasovaa
Copy link
Contributor

Thanks!

@tmszi tmszi deleted the fix_rlisetup_dialog_remove_btn branch July 28, 2020 07:15
@neteler neteler added this to the 8.0.0 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrasovaa petrasovaa petrasovaa requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tmszi @petrasovaa @neteler