Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI gcp: Allow choose map display web service layer as target map to display #654

Merged
merged 1 commit into from
Jul 25, 2020

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented May 20, 2020

wxGUI gcp wizard dialog (select web service layer as target raster map to display):

wxgui_gcp_wizard_dialog

wxGUI gcp editor frame (render web service layer as target raster map)

wxgui_gcp_editor

@neteler neteler added GUI wxGUI related enhancement New feature or request labels May 20, 2020
@tmszi tmszi force-pushed the wxgui_gcp_web_srvc_lyr_as_tgtmap branch from ed2f3a3 to e3d1a47 Compare July 21, 2020 14:21
@neteler
Copy link
Member

neteler commented Jul 25, 2020

I tried this PR in the current master but get an error:

  • g.gui
  • open a WMS
  • File > Georectify
  • error:
Traceback (most recent call last):
  File "/home/mneteler/software/grass_master/dist.x86_64-pc-
linux-gnu/gui/wxpython/lmgr/frame.py", line 547, in
OnGCPManager

GCPWizard(self, self._giface)
  File "/home/mneteler/software/grass_master/dist.x86_64-pc-
linux-gnu/gui/wxpython/gcp/manager.py", line 155, in
__init__

self.mappage = DispMapPage(self.wizard, self)
  File "/home/mneteler/software/grass_master/dist.x86_64-pc-
linux-gnu/gui/wxpython/gcp/manager.py", line 790, in
__init__

extraItems=self.GetSelectTargetRasterExtraItems())
  File "/home/mneteler/software/grass_master/dist.x86_64-pc-
linux-gnu/gui/wxpython/gcp/manager.py", line 983, in
GetSelectTargetRasterExtraItems

self.web_servc_lyrs_root_node_name:
self.GetWebServiceLayers().keys()
  File "/home/mneteler/software/grass_master/dist.x86_64-pc-
linux-gnu/gui/wxpython/gcp/manager.py", line 970, in
GetWebServiceLayers

for layer in self._giface.GetLayerList():
AttributeError
:
'DispMapPage' object has no attribute '_giface'

Maybe a code rebase is needed?

@tmszi tmszi force-pushed the wxgui_gcp_web_srvc_lyr_as_tgtmap branch from e3d1a47 to 17bdfd3 Compare July 25, 2020 14:04
@tmszi
Copy link
Member Author

tmszi commented Jul 25, 2020

I tried this PR in the current master but get an error:

Maybe a code rebase is needed?

Rebase + fix this change in DispMapPage class.

self._giface.GetLayerList() -> self.parent._giface.GetLayerList()

@neteler
Copy link
Member

neteler commented Jul 25, 2020

It is working nicely, a great improvement!

@petrasovaa petrasovaa self-requested a review July 25, 2020 19:30
@petrasovaa petrasovaa merged commit 7da646a into OSGeo:master Jul 25, 2020
@tmszi tmszi deleted the wxgui_gcp_web_srvc_lyr_as_tgtmap branch July 28, 2020 07:17
@neteler neteler added this to the 8.0.0 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GUI wxGUI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants