Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d.barscale: font support added #72

Merged
merged 1 commit into from
Jul 31, 2019
Merged

d.barscale: font support added #72

merged 1 commit into from
Jul 31, 2019

Conversation

neteler
Copy link
Member

@neteler neteler commented Jul 30, 2019

font support added, inspired by d.northarrow

petrasovaa
petrasovaa approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine. The only thing I would consider changing is the gui section, right now the font options are split in Text and Font settings tabs, so moving them all to one of them would be better. I slightly prefer Font settings (or just shorter, Font). This is an issue of d.northarrow as well so maybe a separate commit is needed.

@veroandreo
Copy link
Contributor

veroandreo commented Jul 31, 2019 •
edited
Loading

Thanks for the change! I also tested and works fine. I agree with Anna, though, that we better have all font related stuff into "Font settings" or just "Font" section, i.e., font name, font size and path to font

@neteler neteler merged commit 1ffe4f9 into OSGeo:master Jul 31, 2019
@neteler
Copy link
Member Author

neteler commented Jul 31, 2019

Thanks for the change! I also tested and works fine. I agree with Anna, though, that we better have all font related stuff into "Font settings" or just "Font" section, i.e., font name, font size and path to font

Related ticket opened: https://trac.osgeo.org/grass/ticket/3881

@neteler neteler deleted the d_barscale_font_support branch July 31, 2019 13:17
neteler added a commit that referenced this pull request Jul 31, 2019
@neteler
d.barscale: font support added (#72)
df58e7e
@neteler
Copy link
Member Author

neteler commented Jul 31, 2019

backported to relbr76 in df58e7e

petrasovaa pushed a commit to petrasovaa/grass that referenced this pull request Dec 3, 2019
@neteler @petrasovaa
d.barscale: font support added (OSGeo#72)
415d0cb
@neteler neteler added this to the 7.8.0 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrasovaa petrasovaa petrasovaa approved these changes

@veroandreo veroandreo veroandreo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@neteler @veroandreo @petrasovaa