Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove colouring of standard buttons #744

Merged
merged 1 commit into from
Jul 25, 2020

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Jun 29, 2020

This PR removes the (green) colouring of standard buttons, which as of wxPython 4.1.0 has become a critical readability problem on macOS.

It is preferable to let the OS handle look and behaviour of standard buttons.

Fixes #743

@neteler neteler requested a review from petrasovaa July 25, 2020 09:43
@petrasovaa petrasovaa merged commit ec56b0a into OSGeo:master Jul 25, 2020
@nilason
Copy link
Contributor Author

nilason commented Jul 26, 2020

Thanks!
I plan to put up a new Issue regarding reorganisation of the buttons in general and for generated module dialogs (forms.py) in particular.

@nilason nilason deleted the remove-coloured-buttons branch July 28, 2020 14:38
nilason added a commit to nilason/grass that referenced this pull request Aug 31, 2021
nilason added a commit to nilason/grass that referenced this pull request Aug 31, 2021
nilason added a commit that referenced this pull request Sep 6, 2021
@neteler neteler added this to the 8.0.0 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Remove colouring of standard buttons
3 participants