Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images2gif: PILLOW_VERSION is obsolete #899

Merged
merged 1 commit into from Aug 22, 2020

Conversation

petrasovaa
Copy link
Contributor

Addresses #827.

@veroandreo
Copy link
Contributor

veroandreo commented Aug 14, 2020

I applied this patch with git apply 899.diff in master, and tested.

The byte error reported in #827 does not appear anymore and the animation is generated. However, if I set the filename with extension, eg. bla.gif, I get an output with double gif extension: bla.gif.gif.

If I don't write any extension in the filename (because it seems it gets added there anyway), I get an error:

image

Is this maybe related to #839, @tmszi ?

@tmszi
Copy link
Member

tmszi commented Aug 14, 2020

I applied this patch with git apply 899.diff in master, and tested.

The byte error reported in #827 does not appear anymore and the animation is generated. However, if I set the filename with extension, eg. bla.gif, I get an output with double gif extension: bla.gif.gif.

If I don't write any extension in the filename (because it seems it gets added there anyway), I get an error:

image

Is this maybe related to #839, @tmszi ?

Thanks @veroandreo . Yes, of course my little mistake, I'm sorry. Fixed in the #907. Could you test it please?

@petrasovaa
Copy link
Contributor Author

#907 is merged now.

@petrasovaa petrasovaa merged commit 7df171a into OSGeo:master Aug 22, 2020
petrasovaa added a commit that referenced this pull request Aug 22, 2020
@veroandreo
Copy link
Contributor

shouldn't this be backported? The bug in #827 was originally reported for 7.8.3

@neteler neteler added this to the 7.8.4 milestone Aug 22, 2020
@petrasovaa
Copy link
Contributor Author

Already done, you can see that above, there are 2 commits, if you click on the second one, you should see releasebranch_7_8:
Selection_046

@veroandreo
Copy link
Contributor

ops, sorry for the noise then, and thanks much for the explanation :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] bytes-like error when exporting from g.gui.animation and g.gui.tplot
4 participants