r.geomorphon: translate a C comment into English #972
Conversation
There was a problem hiding this comment.
+1 for the translation. Thanks. Any idea if the meaning is "a change/fix is needed" or "a change [of something] happened"? The context seems to be change from nadir to zenith or the other way around. What do you think @infrastation ?
|
My language abilities in Polish only go as far as guessing the corresponding English word "change" should be used as a noun, not a verb. That is, the meaning is "something has changed", not "fix me". I may be wrong. |
|
Thanks. I would rather err on the side of caution here, so keeping it as is, but I indicated that in the commit message (in addition to this PR) in case somebody investigates that. Merged. Be careful now since you made this PR from your fork's master branch. You may want to check CONTRIBUTING.md or some other Git+GitHub guide to see the full workflow where you create a branch in your fork. This applies even when you are just using the GitHub website. It will be very similar to what you just did. Since you already have modified your master branch, you need to do some extra step to avoid confusion in the future. Unless you made more changes in your fork, you can safely delete it and start over next time. |
|
Thank you! |
Use English for comments. There is still need for review of the actual meaning, but probably just indicating a change from nadir to zenith or the other way around. Comment for the whole block with some more description would be preferred.
No description provided.