Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure.ac: use pkg-config to find proj dependency #24

Merged
merged 1 commit into from Oct 27, 2019
Merged

configure.ac: use pkg-config to find proj dependency #24

merged 1 commit into from Oct 27, 2019

Conversation

ffontaine
Copy link
Contributor

Use pkg-config to retrieve proj and its static dependencies such as
-lstdc++

Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com

Use pkg-config to retrieve proj and its static dependencies such as
-lstdc++

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
@rouault
Copy link
Member

rouault commented Oct 9, 2019

What is the behaviour with this commit if pkg-config itself is not found ?

@ffontaine
Copy link
Contributor Author

I assume that PKG_CHECK_MODULES will return PROJ_FOUND=no and current behavior will be used as fallback.

A call to PKG_PROG_PKG_CONFIG could be added but PKG_CHECK_MODULES is already used for discovering tiff.

However, this PR is useful only if OSGeo/PROJ#1664 is also merged. As stated in the other PR, the other available option, on buildroot side, is to disable libgeotiff for static builds.

@rouault
Copy link
Member

rouault commented Oct 23, 2019

PKG_CHECK_MODULES is already used for discovering tiff.

yes, but as a fallback. Would you mind testing your pull request by temporarily renaming the pkg-config binary ?

@ffontaine
Copy link
Contributor Author

OK, I finally found some time to test my PR with pkg-config binary renamed into "pkg-config-save". In this case, pkg-config is not found (as expected) and proj is found through the current mechanism (through AC_CHECK_LIB).

@rouault rouault merged commit ace9d09 into OSGeo:master Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants