Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of embedded web maps #128

Closed
3 of 5 tasks
jodygarnett opened this issue Oct 12, 2017 · 11 comments
Closed
3 of 5 tasks

Use of embedded web maps #128

jodygarnett opened this issue Oct 12, 2017 · 11 comments

Comments

@jodygarnett
Copy link
Sponsor Contributor

jodygarnett commented Oct 12, 2017

Including maps that are fast and look amazing is important in showcasing our expertise as cartographers and credibility as technologists.

Gretchen has done a great job on the cartography, as we can see in the style guide, this issue is used to double check how well these maps are integrated into our website.

Here are pages that are intended to include both an embedded web map at the top of the page, and a full screen map used to explore.

How to use:

  1. geo-for-all displays map as part of the initial page

  2. list maps (local-chapters, members): use filter dropdown and toggle map

My understanding is the maps were removed from list pages due to design change (to hide filters unless used) and tile performance.

The following I thought would use maps, as they have a location, but it is not supported by the wireframes (as such they can be viewed as an enhancement):

@jodygarnett
Copy link
Sponsor Contributor Author

I am unsure if the non-functioning maps I see are due to browser differences:

Safari

Safari 11.0 http://osgeo.getinteractive.nl/geo-for-all-labs/ Filter --> Toggle Map

  • map displays with no tiles
  • 4 labs are visible as point markers on the map
  • no interaction with these point markers is supported

labsmap-safari

Chrome

Chrome 61.0 11.0 http://osgeo.getinteractive.nl/geo-for-all-labs/ Filter --> Toggle Map

  • no tiles initially, hammering refresh repeatedly caused them to fill in
  • additonal labs visible
  • no interaction with point markers is supported

labsmap-chrome

Firefox

Firefox 56.0 http://osgeo.getinteractive.nl/geo-for-all-labs/ Filter --> unable to display filter dropdown!

  • unable to verify map functionality

Firefox 56.0 http://osgeo.getinteractive.nl/initiatives/geo-for-all/

  • embedded map not displayed

labsmap-firefox

@vloemans-marc
Copy link

Using an iPhone 6 Plus, I don't see any maps on screen. Have filed a bug (first ever in my life...what's next....me coding ;-)

@jodygarnett
Copy link
Sponsor Contributor Author

And to think many individuals start their open source journey by filing an issue; you are just taking a different approach @vloemans-marc .

@gisnederland
Copy link

on Win10 - 64 bitOS:
http://osgeo.getinteractive.nl/geo-for-all-labs/
chrome (61.0.3163.100): tiles display OK / point markers display OK but no interaction
IE (11.674): Header (text) and footer (sponsors) of page loads, middle part with labs does not load at all
Edge: tiles display OK / point markers display OK but no interaction
FireFox (56.0.1): button filter does not respond

@gisnederland
Copy link

On Android 6.0.1
http://osgeo.getinteractive.nl/geo-for-all-labs/
chrome (61.0.3163.98): tiles display OK / point markers display OK but no interaction

@gisnederland
Copy link

On Android (tablet)
http://osgeo.getinteractive.nl/geo-for-all-labs/
chrome (55.0.2883.91): tiles display OK / point markers display OK but no interaction
standard android browser (4.3.1-1754): page won't load (middle part with labs doesn't load).

@ghost
Copy link

ghost commented Oct 25, 2017

Firefox 56.0 http://osgeo.getinteractive.nl/geo-for-all-labs/ Filter --> unable to display filter dropdown!
Firefox 56.0 http://osgeo.getinteractive.nl/initiatives/geo-for-all/
embedded map not displayed

Filter dropdown is now working and map is displayed in Firefox.

@gisnederland
Copy link

Regarding IE:
debugging shows erros "promise is not defined"

Possible solution:
https://stackoverflow.com/questions/36831372/promise-is-undefined-in-ie

@gisnederland
Copy link

standard Android (4.3.1) browser on Samsung tablet still not working as well.
Perhaps the same "promise"-problem?

@ghost
Copy link

ghost commented Nov 8, 2017

Regarding IE:
debugging shows erros "promise is not defined"

The promise error is fixed by using the polyfill.

Also the interaction that was missing is added to the maps.

standard Android (4.3.1) browser on Samsung tablet still not working as well.
Perhaps the same "promise"-problem?

@gisnederland Could you test the new version of the map on that specific Android version? I tested on other versions and it works, but I don't have that specific version available.

@gisnederland
Copy link

Works like a charm on the Android 4.3.1 browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants