Skip to content
This repository has been archived by the owner on May 18, 2022. It is now read-only.

Add Canadian provincial horizontal shift grids #61

Merged
merged 2 commits into from
Nov 25, 2019

Conversation

rouault
Copy link
Member

@rouault rouault commented Nov 23, 2019

Retrieved from https://webapp.geod.nrcan.gc.ca/geod/data-donnees/transformations.php?locale=en
Subject to Open Government Licence - Canada (as ntv2_0.gsb we already ship)

Regarding filename case, this is a mess. Most of the files coming from the
source use upper cases for extension.
But some of them have .GSB uppercase in the HTML name, but once unzipped,
they use .gsb (but EPSG refers most of time as .GSB sometimes)
In other cases, the source use .GSB, but EPSG refers to .gsb
So... for consistency I ended up using .GSB for this batch (the ntv2_0.gsb
is historically due to old PROJ referin it to it)

Addresses OSGeo/PROJ#202

Retrieved from https://webapp.geod.nrcan.gc.ca/geod/data-donnees/transformations.php?locale=en
Subject to Open Government Licence - Canada (as ntv2_0.gsb we already ship)

Regarding filename case, this is a mess. Most of the files coming from the
source use upper cases for extension.
But some of them have .GSB uppercase in the HTML name, but once unzipped,
they use .gsb (but EPSG refers most of time as .GSB sometimes)
In other cases, the source use .GSB, but EPSG refers to .gsb
So... for consistency I ended up using .GSB for this batch (the ntv2_0.gsb
is historically due to old PROJ referin it to it)
Copy link
Member

@kbevers kbevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the white-space thing I commented on, this looks good to me. I haven't checked the grids but I trust you to submit ones that work!

@@ -47,8 +272,8 @@ grid coordinates are referenced to GR96.

### USA: NAD83 -> NAD83 (HARN/HPGN)

*Source*: [.los/.las files coming from NOAA](https://www.ngs.noaa.gov/PC_PROD/NADCON/NADCON.zip)
*Format*: NTv2
*Source*: [.los/.las files coming from NOAA](https://www.ngs.noaa.gov/PC_PROD/NADCON/NADCON.zip)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bunch of changes like this from here and below. Seems unnecessary to me but maybe there's a point?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there are necessary for correct GitHub formatting. Otherwise the lines get concatenated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, okay. Stuff like that usually catches my eyes instantly because I have my editor set up to remove trailing whitespace on save. So I would probably remove them by mistake if I were to edit that file...

@rouault rouault added this to the datumgrid-north-america-1.3 milestone Nov 25, 2019
@rouault rouault merged commit acc7e77 into OSGeo:master Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants