Skip to content

Commit

Permalink
Rename gie_failing to work around MS wildcard bug (#799)
Browse files Browse the repository at this point in the history
For reasons unknown to anyone but the geniuses from Redmond: In
MSWindows, the wildcard pattern "*.gie" expands to all files having
an extension *starting* with ".gie".

In other words "dir *.gie" will list files with extension ".gie"
*and* with extension ".gie_failing".

This means that running "gie test\gigs\*.gie" will run all gigs
tests, even the ones known to fail.

So rather than getting a quick check for regressions, one gets
a lot of noise and no easy way to be sure whether any regressions
have appeared.

To work around this oddity, we rename all files ending in
".gie_failing" to end in ".gie.failing" - and while at it,
adding all the non-failing gigs tests to the AppVeyor test suite.

This extends the regression test suite, run at the end of each
AppVeyor integration, to over 2500 individual tests.

Test coverage, however, is still hovering just below 75%, so
there's still plenty of room and reason for additional tests.
  • Loading branch information
busstoptaktik committed Feb 12, 2018
1 parent 715ec0b commit ab2d175
Show file tree
Hide file tree
Showing 14 changed files with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion appveyor.yml
Expand Up @@ -62,7 +62,7 @@ test_script:
- dir ..\test\gie
- echo "Contents of PROJ_LIB " %PROJ_LIB%
- dir %PROJ_LIB%
- gie.exe ..\test\gie\*.gie
- gie.exe ..\test\gie\*.gie ..\test\gigs\*.gie

deploy: off

File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 comments on commit ab2d175

Please sign in to comment.