Check for sweep_axis being an empty string in PJ_geos. #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found with autofuzz MemorySanitizer: use-of-uninitialized-value
rouault
reviewed
Mar 27, 2018
src/PJ_geos.c
Outdated
| @@ -206,7 +206,8 @@ PJ *PROJECTION(geos) { | |||
| if (sweep_axis == NULL) | |||
| Q->flip_axis = 0; | |||
| else { | |||
| if (sweep_axis[1] != '\0' || (sweep_axis[0] != 'x' && sweep_axis[0] != 'y')) | |||
| if (sweep_axis[0] == '\0' || sweep_axis[1] != '\0' || | |||
There was a problem hiding this comment.
more complicated that needed. You could just invert the 2 clauses of the original condition
if ((sweep_axis[0] != 'x' && sweep_axis[0] != 'y') || sweep_axis[1] != '\0')
There was a problem hiding this comment.
Thanks! I was thinking along the same lines after doing a patch that followed the local style. I was thinking about strnlen, but I prefer your suggestion.
Suggested by rouault
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found with autofuzz MemorySanitizer: use-of-uninitialized-value
\0 after sweep causes the failure:
+proj=geos +h=17892900000020003z + +sweep^@+