Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up time handling in helmert and deformation #1264

Merged
merged 5 commits into from Feb 14, 2019

Conversation

Projects
None yet
1 participant
@kbevers
Copy link
Member

kbevers commented Feb 14, 2019

Previous to this PR both helmert and deformation and had +t_obs parameters. They are removed with this PR. Removed from helmert because it never worked (described in #1239) and in deformation because it was potentially confusing. In deformation +t_obs has been replaced with +dt which allow users to specifiy a time-span directly instead of having to set both +t_epoch and +t_obs.

Additionally the dt convention has been changed in deformation from t_central-t_obs to t_obs-t_central so that it follows the same conventions as used in helmert (further described in #1242).

Closes #1239
Closes #1242

kbevers added some commits Feb 1, 2019

Reverse direction of deformation operations/transformations/deformation
Changed the direction of dt-calculation to follow the same convention as
helmert. Changed from dt = t_c - t_obs to dt = t_obs - t_c, which
effectively reverses the direction of the operation. Existing projstrings
using deformation can simply reverse the direction of the operation to
achieve the same results as before this commit.
deformation: Replace +t_obs with +dt
The +t_obs parameter was confusing for users since it effectively
overwrote the observation time in input coordinates. To make it more clear
what is the operation is doing, users are now required to directly specify
the time span for which they wish to apply a given deformation. The parameter
+dt has been added for that purpose. The new parameter is mutually
exclusive with +t_epoch. +dt is used when deformation
for a set amount of time is needed and +t_epoch is used (in
conjunction with the observation time of the input coordinate) when
deformation from a specific epoch to the observation time is needed.

@kbevers kbevers merged commit a813ad6 into OSGeo:master Feb 14, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage decreased (-0.002%) to 85.447%
Details

@kbevers kbevers deleted the kbevers:remove-t_obs branch Feb 14, 2019

@kbevers kbevers added this to the 6.0.0 milestone Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.