Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up time handling in helmert and deformation #1264

Merged
merged 5 commits into from Feb 14, 2019

Commits on Feb 1, 2019

  1. Copy the full SHA
    15a225b View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2019

  1. Reverse direction of deformation operations/transformations/deformation

    Changed the direction of dt-calculation to follow the same convention as
    helmert. Changed from dt = t_c - t_obs to dt = t_obs - t_c, which
    effectively reverses the direction of the operation. Existing projstrings
    using deformation can simply reverse the direction of the operation to
    achieve the same results as before this commit.
    kbevers committed Feb 14, 2019
    Copy the full SHA
    29a59ca View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    82855db View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    3655269 View commit details
    Browse the repository at this point in the history
  4. deformation: Replace +t_obs with +dt

    The +t_obs parameter was confusing for users since it effectively
    overwrote the observation time in input coordinates. To make it more clear
    what is the operation is doing, users are now required to directly specify
    the time span for which they wish to apply a given deformation. The parameter
    +dt has been added for that purpose. The new parameter is mutually
    exclusive with +t_epoch. +dt is used when deformation
    for a set amount of time is needed and +t_epoch is used (in
    conjunction with the observation time of the input coordinate) when
    deformation from a specific epoch to the observation time is needed.
    kbevers committed Feb 14, 2019
    Copy the full SHA
    12689e3 View commit details
    Browse the repository at this point in the history