Add tests for C99 math functions, hypot, atanh, cbrt, etc. #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tests whether the functions are declared in <math.h>. If they are, then -DHAVE_C99_MATH=1 is added to the C flags. The intention is that this flag is only seen when building proj.4 and shouldn't be referenced in any of the installed include files. The next update to geodesic.c will use this flag. Left unaddressed is what to do if HAVE_C99_MATH is 0. The strategy in geodesic.c is to assume that the missing functions will need to be defined explicitly. A less safe alternative is to assume that the functions are in fact available in libm and that all that needs to be done is to declare the functions.
|
I suppose an additional test could be made where math.h is missing these functions to see if libm has them defined nevertheless. Probably it would be best to formulate a general strategy first. Presumably at some point we can declare that proj.4 requires a C99 (or later) compliant compiler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests whether the functions are declared in <math.h>. If they are,
then -DHAVE_C99_MATH=1 is added to the C flags. The intention is that
this flag is only seen when building proj.4 and shouldn't be referenced
in any of the installed include files. The next update to geodesic.c
will use this flag.
Left unaddressed is what to do if HAVE_C99_MATH is 0. The strategy in
geodesic.c is to assume that the missing functions will need to be
defined explicitly. A less safe alternative is to assume that the
functions are in fact available in libm and that all that needs to be
done is to declare the functions.