Replace pj_ell_set with reimplementation... #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OS/X appears to have a slightly off float handling, resulting in differences at the nanometer level. Switching to 10 nm.
kbevers
added a commit
to kbevers/PROJ
that referenced
this pull request
Mar 11, 2018
Functions should only be prefixed with 'pj_' when they can be used in other parts of the code base and not just within a single file. Takes care of the last step in OSGeo#675.
kbevers
added a commit
that referenced
this pull request
Mar 12, 2018
Functions should only be prefixed with 'pj_' when they can be used in other parts of the code base and not just within a single file. Takes care of the last step in #675.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...supporting ellipsoid inheritance.
This is a replacement for the clasic PROJ pj_ell_set function.
The main difference is that pj_ellipsoid augments the PJ object with a copy of the exact tags used to define its related ellipsoid.
This makes it possible to let a new PJ object inherit the exact geometrical properties of an existing one.
A complete ellipsoid definition comprises a primary (size) and a secondary (shape) parameter. It may include a spherification parameter, that turns an ellipsoid into a sphere with radius defined from the ellipsoidal parameters (e.g. a sphere with same surface area or volume as the ellipsoid).