Overhaul ellipsoid handling #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(AppVeyor reports error on one build that cannot complete, due to effects unrelated to this PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although this PR started with an ambition of improving the error messaging of
cctandgie, when a number of minor bugs and misimplementations were discovered, it morphed into a medium-sized overhaul of the ellipsoid handling.This includes the renaming of a few functions from the
proj_internal.hpj_-namespace, for better consistency (which makes the code inpj_ell_set.ca bit easier to read), and a number of clean ups spread out over the code carpet.The original goal of improved error messaging was also kept, and fulfilled, although it is now a minor corner of the PR. It was, however, that effort which revealed the bugs now squashed, so splitting it out in a separate PR is only marginally meaningful.