Minor cleanup of pj_phi2.c #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- tabs -> spaces - IWYU - #define -> static const typed - Combine definition and initialization - Define one var per statement - Use the defined symbol rather than embedding bare literals -18 -> PJD_ERR_NON_CON_INV_PHI2 Subset of fixes discussed in OSGeo#971
error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
|
Looks good to me. I think it would be nice if you added the descriptive comment Charles suggested in the previous PR. Or something to that effect if it doesn't fit a 100% in this less radically changed version of the code. |
|
kbevers@: Docs added |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-18 -> PJD_ERR_NON_CON_INV_PHI2
Subset of fixes discussed in #971