Switch to 2.3.0-SNAPSHOT in the RM adaptor

[berezovskyi]

This is the code needed to maintain the non-abbrev output, see more details in https://issues.apache.org/jira/browse/JENA-1477

---

This change is 

[jamsden]

Is this now out of date based on:
We will:

1. Depend on 'apache-jena-libs' instead of the individual artefacts.
2. Replace calls to 'model.getWriter("RDF/XML")' with the invocation of the RDFDataManager 'RDFDataMgr.write(outputStream, model, RDFFormat.RDFXML_PLAIN);'.

[jadelkhoury]

replacing model.getwriter() in the jena-provider project seems to be the proper way to go. If we want to do that, @berezovskyi is arguing that we should do a proper refactoring of the provider classes in the jena-provider project. Do you have the time/effort to do it?
There are many Jax-RS providers that handle XML/RDF. but from my analysis of these classes, they all end up in the AbstractOslcRdfXmlProvider.java class.

The alternative above is the hack because it is based on private classes of Jena (within an adaptor) that gives you the same result, in the short term, without touching Jena-provider.

[berezovskyi]

Well, I actually did develop a Universal provider but that patch needs more work eclipse/lyo.core#9

[jamsden]

Should we make these changes in OSLC4J instead?

1. Depend on 'apache-jena-libs' instead of the individual artefacts.
2. Replace calls to 'model.getWriter("RDF/XML")' with the invocation of the RDFDataManager 'RDFDataMgr.write(outputStream, model, RDFFormat.RDFXML_PLAIN);'.

[berezovskyi]

Absolutely, we should make the changes to the OSLC4J if we expect the majority of the Lyo users to come in contact with the legacy apps that can't parse all variants of conformant RDF (typed node elements were legit even in RDF 1.0 https://www.w3.org/TR/2004/REC-rdf-syntax-grammar-20040210/#section-Syntax-typed-nodes).

Here is a list of things we need to do:

• CQ the apache-jena-libs:3.0.1
• Remove code duplication from AbstractOslcRdfXmlProvider.
  • The reason we need to do that is that the writer.write() is duplicated. See the image below, nothing special.
• Consolidate the (media type, system prefs) -> (jena format) conversion so that we can manipulate the format cleanly (plain RDF / RDF with typed nodes etc.). Right now we have the following methods:
  • isAcceptableMediaType
  • isCompatible
  • getSerializationLanguage
  • also we have org.eclipse.lyo.oslc4j.alwaysXMLAbbrevOnlyProviders property
• stop using strings like "RDF/XML" for Jena and use https://jena.apache.org/documentation/javadoc/arq/org/apache/jena/riot/RDFFormat.html

[berezovskyi]

But I think that legacy-talking code can either call

ModelFactory.createDefaultModel();
RDFWriterFImpl.alternative(null);

Or we can add a static method in Lyo with these two lines.

[berezovskyi]

I am sorry to write this, but I completely lost the context why did we need to force any kind of Jena model writer?

Also,

• switch to Jena 2.4.0-SNAPSHOT artifacts

[jamsden]

This was required to get the RFD/XML to output a specific format that the jazz-app web applications are expecting.

[berezovskyi]

What do you want to do with this patch then? Include it in the codegen? Or add it to the wiki? –Andrew. (sent from my phone)

…

On 2 Jul 2018, at 13:29, Jim Amsden ***@***.***> wrote: This was required to get the RFD/XML to output a specific format that the jazz-app web applications are expecting. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[jamsden]

Add it to the wiki. Its noise in the code generator. Jim Amsden, Senior Technical Staff Member OSLC and Linked Lifecycle Data 919-525-6575 From: Andrew Berezovskyi <notifications@github.com> To: OSLC/lyo-adaptor-sample-modelling <lyo-adaptor-sample-modelling@noreply.github.com> Cc: Jim Amsden <jamsden@us.ibm.com>, Review requested <review_requested@noreply.github.com> Date: 07/02/2018 02:24 PM Subject: Re: [OSLC/lyo-adaptor-sample-modelling] Switch to 2.3.0-SNAPSHOT in the RM adaptor (#12) What do you want to do with this patch then? Include it in the codegen? Or add it to the wiki? –Andrew. (sent from my phone)

On 2 Jul 2018, at 13:29, Jim Amsden ***@***.***> wrote: This was required to get the RFD/XML to output a specific format that

the jazz-app web applications are expecting.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or mute the thread.

[berezovskyi]

Do you think you could do that, Jim, please? :)

[berezovskyi]

@jadelkhoury what's the status on this one?

[jadelkhoury]

I don’t think we should be merging branches in this project. The code on master is meant to be generated. So if we want to make changes to the code, this ought to be done in the generator.
I have normally created branches here to experiment or illustrate how the generated code is meant to look like. But once we decide, the change/branch is made in the Lyo.designer repo.

[jadelkhoury]

From what I read above, we should just kill this branch?