6807 add exit codes to setup session.rb #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration
Integration
Integration
Integration
| exit_code = $?.exitstatus | ||
| raise "failed command: #{shell}" unless exit_code==0 | ||
|
|
||
| rescue Exception => error |
There was a problem hiding this comment.
Your raise is caught with rescue and is not really thrown. Is it supposed to be so? Application will not return 1.
There was a problem hiding this comment.
It supposed for this, because it is working in cycle, and maybe will be some exceptions at setup, which will not be reason to exit from cycle.
|
|
||
| puts "#{shellCommand}\n" | ||
| # just one soft exeption - box already exist | ||
| if shellCommand[/attempting to add already exists/]==nil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise if don't exist directory\files and rescue shell - errors.
P.S. File exists maybe not work.