Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSMCha mixes changes of multiple changesets in one #492

Open
tordans opened this issue Nov 9, 2020 · 6 comments
Open

OSMCha mixes changes of multiple changesets in one #492

tordans opened this issue Nov 9, 2020 · 6 comments

Comments

@tordans
Copy link
Contributor

tordans commented Nov 9, 2020

I'm submitting a bug report

This is wrong:

image

However:
https://www.openstreetmap.org/node/1455122211/history
The history shows, that those changes are done in two separate changesets.

  1. #93550765 => adds the crossing:island
    https://www.openstreetmap.org/changeset/93550765
    https://osmcha.org/changesets/93550765?filters=%7B%22users%22%3A%5B%7B%22label%22%3A%22dAnjou%22%2C%22value%22%3A%22dAnjou%22%7D%5D%7D
  2. #93550776 => adds the tactile_paving
    https://www.openstreetmap.org/changeset/93550776
    https://osmcha.org/changesets/93550776?filters=%7B%22users%22%3A%5B%7B%22label%22%3A%22dAnjou%22%2C%22value%22%3A%22dAnjou%22%7D%5D%7D
@willemarcel
Copy link
Collaborator

@tordans We've implemented some changes on how we generate the map visualization today. Let me know if you find some other similar case.

Related to osmlab/changeset-map#102

@matkoniecz
Copy link

matkoniecz commented Nov 14, 2020

The same happens with https://osmcha.org/changesets/94100583/ (compare https://www.openstreetmap.org/changeset/94100583 ) - "Add housenumbers" changeset is incorrectly shown as adding lit=yes tags

It clearly causes significant confusion - see streetcomplete/StreetComplete#2272 and streetcomplete/StreetComplete#2253

screen

@tordans
Copy link
Contributor Author

tordans commented Nov 15, 2020

It is still happening at https://osmcha.org/changesets/94151729?filters=%7B%22users%22%3A%5B%7B%22label%22%3A%22dAnjou%22%2C%22value%22%3A%22dAnjou%22%7D%5D%7D

From quickly reading over osmlab/changeset-map#102, it might be needed to explain in the UI, what is going on.

@andrewharvey
Copy link

wonder if this is the same root cause as #467

@fnordiff
Copy link

I just noticed that OSMCha seems to have the colored numbers in the details overlay correct in these cases. You can see that in the screenshot above (changeset 94100583) #492 (comment)

It says "4" in yellow and zero in green/red, which corresponds to the four ways listed in https://www.openstreetmap.org/changeset/94100583 . I've noticed this behavior in other changesets as well.

So the data in the detail "overlay" in front of the map and the "changeset list" on the left seem to be correct, just not the representation on the map, which also highlights things that have not changed in this changeset.

@mxxcon
Copy link

mxxcon commented Feb 9, 2024

This problem is still going on. It's especially problematic with changesets coming from StreetComplete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants