Loads of API fixes and tweaks #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a array for the tabs to be added to and updated the getCurrentTab method to use this Fixed the debug method for displaying the current tab *was trying to get the widget ID in an array of less than 10* Fixed the random scripts displaying null as their name *was commented out* Updated the LoginScript ScriptManifest Fixed player position debug Fixed an error in getting local positions from a tile *was previously trying to convert local position coordinates directly into the scene coordinates* Fixed an invalid cast in NPCs getAll function Fixed several calculation methods to properly provide the information we desire Added nullchecks to several debug functions so they could properly continue Replaced a line in debuginventory to properly reference what the item in the inventory has (was trying to get as a component which was null) Removed the odd height argument being passed by debugs Bugs noted: Mouse Value isn't updated by the actual user mouse, but rather only the virtual mouse. Not super useful for debug
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a array for the tabs to be added to and updated the getCurrentTab method to use this
Fixed the debug method for displaying the current tab was trying to get the widget ID in an array of less than 10
Fixed the random scripts displaying null as their name was commented out
Updated the LoginScript ScriptManifest
Fixed player position debug
Fixed an error in getting local positions from a tile was previously trying to convert local position coordinates directly into the scene coordinates
Fixed an invalid cast in NPCs getAll function
Fixed several calculation methods to properly provide the information we desire
Added nullchecks to several debug functions so they could properly continue
Replaced a line in debuginventory to properly reference what the item in the inventory has (was trying to get as a component which was null)
Removed the odd height argument being passed by debugs
Bugs noted: Mouse Value isn't updated by the actual user mouse, but rather only the virtual mouse. Not super useful for debug