fix: fatal runtime error: stack overflow when try use ArchiveIteratorBuilder.filter()

[alandeev]

problem

When trying to use the "filter" function of ArchiveIteratorBuilder in "rar/zip/7z" with large amounts of files ( in my case 24 thousand ) and implement some rule in the "filter", the program ends up breaking if it doesn't "match" during thousands of files traversed, because if the "filter" does not "match" during each chunk, it calls "self.next()" again recursively to process the next chunk/header, thus filling the call stack and causing a "fatal runtime error".

solution

I removed the recursion and added a loop.

[otavio]

I noticed that the formatting error in the code has been fixed. I have sent a revised code for your review in the branch. Additionally, it would be great if you could add an item to the CHANGES.md file to document the change.

[alandeev]

@otavio
OK. sorry for the problems, i'm new trying to help in open source :) I'm still getting familiar with the rules.

I will again correct the problems that occurred in the actions and a doubt I have is where can I add this change in "CHANGES.md", would it be below the "## [Unreleased] - ReleaseDate" right?

[otavio]

Yes, it'll be below it.

[otavio]

No worries, I am happy to help :-)

[otavio]

I did minor changes and squashed the commits.

[otavio]

Released 0.14.2.

[coveralls]

Pull Request Test Coverage Report for Build 5051902929

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-1.4%) to 83.951%

---

Files with Coverage Reduction	New Missed Lines	%
src/lib.rs	1	72.46%

Totals
Change from base Build 4482848134:	-1.4%
Covered Lines:	340
Relevant Lines:	405

---

💛 - Coveralls