Add a function to list all files in a archive #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 149870013
💛 - Coveralls |
Asakiz
force-pushed
the
topic/enhancement
branch
3 times, most recently
from
4e02fb1
to
2b20921
Compare
otavio
requested changes
Jun 27, 2020
There was a problem hiding this comment.
@Asakiz thanks for looking into it. Please take a look at the comments I made below.
Another thing we need to look at is because the minimal Rust version will need to be moved to 1.40.0 due to the doctest feature use. Please add it as another commit.
Asakiz
force-pushed
the
topic/enhancement
branch
from
2b20921
to
85f66ec
Compare
otavio
force-pushed
the
topic/enhancement
branch
from
2f6c5ec
to
7ac6ca5
Compare
otavio
approved these changes
Jun 28, 2020
otavio
force-pushed
the
topic/enhancement
branch
from
7ac6ca5
to
b0f79a6
Compare
Signed-off-by: asakiz <asakizin@gmail.com>
Fixes: #22 Signed-off-by: asakiz <asakizin@gmail.com> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
otavio
force-pushed
the
topic/enhancement
branch
from
b0f79a6
to
e51c023
Compare
|
Prior merging it I made few minor adjustments:
|
|
As requested, I tried the master branch, and it works nicely. Thank you for your efforts! |
|
@Aloso thanks for testing it. We made the 0.6.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: asakiz asakizin@gmail.com