Plug some memory leaks #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We avoid now calling `.into_raw()` so we don't need to read the raw pointer back, to free it. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Pull Request Test Coverage Report for Build 254755556
💛 - Coveralls |
otavio
changed the title
otavio
force-pushed
the
topic/fix-leak
branch
from
06564ad
to
109a2b7
Compare
We need to always handle the cleanup of resources even when we are catching errors so to avoid a lot of code duplication we wrap the internal logic into a lambda. Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
otavio
force-pushed
the
topic/fix-leak
branch
from
109a2b7
to
e2bfb15
Compare
Jonathas-Conceicao
approved these changes
Sep 15, 2020
otavio
added a commit
that referenced
this pull request
Sep 15, 2020
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We avoid now calling
.into_raw()so we don't need to read the rawpointer back, to free it. Also, we reworked the error handling so it
ensures the resource cleanup runs even in error cases.
Signed-off-by: Otavio Salvador otavio@ossystems.com.br