Chromium 120.0.6099.224 fails to build with master OE #786
Comments
|
I had the same issue: #785 I'm on kirkstone, and using the kirkstone/rust-1.70 branch of meta-lts-mixins gave me a working build. Seems you need rust with profiler support enabled as well. The recent rust recipes in oe-core and meta-lts-mixins disable the profiler: https://git.yoctoproject.org/poky/commit/meta/recipes-devtools/rust?id=321aebfa281bd28e368c684ece57867f6bd0cbe7 The kirkstone/rust-1.70 (and kirkstone/rust-1.68) branches still have the profiler enabled. |
|
You are correct that this dependency is apparently needed which is indeed a problem. However, having enabled it again I bump into the next problem: [4560/63971] python3 ../../third_party/catapult/tracing/bin/generate_about_tracing_contents --outdir gen/content/browser/tracing
FAILED: gen/content/browser/tracing/about_tracing.js gen/content/browser/tracing/about_tracing.html
python3 ../../third_party/catapult/tracing/bin/generate_about_tracing_contents --outdir gen/content/browser/tracing
/home/tom/projects/Estalor-Yocto/build/tmp/work/cortexa72-oe-linux/chromium-ozone-wayland/120.0.6099.224/chromium-120.0.6099.224/third_party/catapult/common/py_vulcanize/py_vulcanize/html_generation_controller.py:21: SyntaxWarning: invalid escape sequence '\('
if re.search('url\(.+\)', contents):
/home/tom/projects/Estalor-Yocto/build/tmp/work/cortexa72-oe-linux/chromium-ozone-wayland/120.0.6099.224/chromium-120.0.6099.224/third_party/catapult/common/py_vulcanize/py_vulcanize/style_sheet.py:63: SyntaxWarning: invalid escape sequence '\('
return re.sub('url\((?P"|\'|)(?P[^"\'()]*)(?P=quote)\)',
/home/tom/projects/Estalor-Yocto/build/tmp/work/cortexa72-oe-linux/chromium-ozone-wayland/120.0.6099.224/chromium-120.0.6099.224/third_party/catapult/common/py_vulcanize/py_vulcanize/style_sheet.py:75: SyntaxWarning: invalid escape sequence '\('
'url\((?:["|\']?)([^"\'()]*)(?:["|\']?)\)',
/home/tom/projects/Estalor-Yocto/build/tmp/work/cortexa72-oe-linux/chromium-ozone-wayland/120.0.6099.224/chromium-120.0.6099.224/third_party/catapult/common/py_vulcanize/py_vulcanize/js_utils.py:7: SyntaxWarning: invalid escape sequence '\/'
return js.replace('</script>', '<\/script>')
|
|
I already stumbled across this myself at the end of last week but didn't have the time yet to take a closer look (and forgot to file an issue). Thanks for reporting, and also thanks to @bobolopolis for figuring out the cause! I'll think about how to best fix this, and will check the |
|
Removing I'm now also getting the same warnings errors as @Gerry546. I suspect that this is due to master's update from Python 3.11 to 3.12. Chromium tracks this at https://issues.chromium.org/issues/40283283, which e.g. also mentions the I'll re-visit this issue once the m122 update is ready, and hopefully we can just include the |
MaxIhlenfeldt
changed the title
|
Hm, I just realized that the next update I'll do is m121, not m122. I'll see if it's feasible to backport the patches needed to fix the Python 3.12 issues. |
|
@MaxIhlenfeldt have you considered sending the rust bbappends changes to oe-core / master and to the kirkstone mixing layer? |
|
The profiler option was disabled in oe-core master to fix rust reproducibility issues but it is enabled in kirkstone branch and build works fine there. We can check the bbappends changes and then send it oe-core, if everything works fine. |
I'd be very grateful if you could handle that! |
Quick update: backporting https://crrev.com/c/5092950 should fix the compilation with Python 3.12. I'll include it in the m121 update, which I'll upload soon. |
The rust profiler PGO (Profile-guided Optimization) options was disabled as a part rustdoc reproducibility fix. https://git.yoctoproject.org/poky/commit/meta/recipes-devtools/rust?id=321aebfa281bd28e368c684ece57867f6bd0cbe7 But, other applications (such as to build chromium with poky) requires PGO enabled (OSSystems/meta-browser#786). For reproducibility issue fix only "rust-demangler" change is sufficient in commit#321aebfa281. The PGO is reverted to it's default. (From OE-Core rev: 8a3049bc1abf5b4ca4e30598ed88dd68e42e8d1b) Signed-off-by: Yash Shinde <Yash.Shinde@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The rust profiler PGO (Profile-guided Optimization) options was disabled as a part rustdoc reproducibility fix. https://git.yoctoproject.org/poky/commit/meta/recipes-devtools/rust?id=321aebfa281bd28e368c684ece57867f6bd0cbe7 But, other applications (such as to build chromium with poky) requires PGO enabled (OSSystems/meta-browser#786). For reproducibility issue fix only "rust-demangler" change is sufficient in commit#321aebfa281. The PGO is reverted to it's default. Signed-off-by: Yash Shinde <Yash.Shinde@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The rust profiler PGO (Profile-guided Optimization) options was disabled as a part rustdoc reproducibility fix. https://git.yoctoproject.org/poky/commit/meta/recipes-devtools/rust?id=321aebfa281bd28e368c684ece57867f6bd0cbe7 But, other applications (such as to build chromium with poky) requires PGO enabled (OSSystems/meta-browser#786). For reproducibility issue fix only "rust-demangler" change is sufficient in commit#321aebfa281. The PGO is reverted to it's default. (From OE-Core rev: 8a3049bc1abf5b4ca4e30598ed88dd68e42e8d1b) Signed-off-by: Yash Shinde <Yash.Shinde@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The rust profiler PGO (Profile-guided Optimization) options was disabled as a part rustdoc reproducibility fix. https://git.yoctoproject.org/poky/commit/meta/recipes-devtools/rust?id=321aebfa281bd28e368c684ece57867f6bd0cbe7 But, other applications (such as to build chromium with poky) requires PGO enabled (OSSystems/meta-browser#786). For reproducibility issue fix only "rust-demangler" change is sufficient in commit#321aebfa281. The PGO is reverted to it's default. (From OE-Core rev: 8a3049bc1abf5b4ca4e30598ed88dd68e42e8d1b) Signed-off-by: Yash Shinde <Yash.Shinde@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The rust profiler PGO (Profile-guided Optimization) options was disabled as a part rustdoc reproducibility fix. https://git.yoctoproject.org/poky/commit/meta/recipes-devtools/rust?id=321aebfa281bd28e368c684ece57867f6bd0cbe7 But, other applications (such as to build chromium with poky) requires PGO enabled (OSSystems/meta-browser#786). For reproducibility issue fix only "rust-demangler" change is sufficient in commit#321aebfa281. The PGO is reverted to it's default. (From OE-Core rev: 8a3049bc1abf5b4ca4e30598ed88dd68e42e8d1b) Signed-off-by: Yash Shinde <Yash.Shinde@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The rust profiler PGO (Profile-guided Optimization) options was disabled as a part rustdoc reproducibility fix. https://git.yoctoproject.org/poky/commit/meta/recipes-devtools/rust?id=321aebfa281bd28e368c684ece57867f6bd0cbe7 But, other applications (such as to build chromium with poky) requires PGO enabled (OSSystems/meta-browser#786). For reproducibility issue fix only "rust-demangler" change is sufficient in commit#321aebfa281. The PGO is reverted to it's default. (From OE-Core rev: 83bd5e12e069a60a870a7c7ed046a2827eb777a1) Signed-off-by: Yash Shinde <Yash.Shinde@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The rust profiler PGO (Profile-guided Optimization) options was disabled as a part rustdoc reproducibility fix. https://git.yoctoproject.org/poky/commit/meta/recipes-devtools/rust?id=321aebfa281bd28e368c684ece57867f6bd0cbe7 But, other applications (such as to build chromium with poky) requires PGO enabled (OSSystems/meta-browser#786). For reproducibility issue fix only "rust-demangler" change is sufficient in commit#321aebfa281. The PGO is reverted to it's default. Signed-off-by: Yash Shinde <Yash.Shinde@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The rust profiler PGO (Profile-guided Optimization) options was disabled as a part rustdoc reproducibility fix. https://git.yoctoproject.org/poky/commit/meta/recipes-devtools/rust?id=321aebfa281bd28e368c684ece57867f6bd0cbe7 But, other applications (such as to build chromium with poky) requires PGO enabled (OSSystems/meta-browser#786). For reproducibility issue fix only "rust-demangler" change is sufficient in commit#321aebfa281. The PGO is reverted to it's default. Signed-off-by: Yash Shinde <Yash.Shinde@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
|
How do you manage to apply this as a backport? I cannot seem to And I can't add this as a patch directly via a |
|
Thanks. That works. :) Good to have something compile again |
The rust profiler PGO (Profile-guided Optimization) options was disabled as a part rustdoc reproducibility fix. https://git.yoctoproject.org/poky/commit/meta/recipes-devtools/rust?id=321aebfa281bd28e368c684ece57867f6bd0cbe7 But, other applications (such as to build chromium with poky) requires PGO enabled (OSSystems/meta-browser#786). For reproducibility issue fix only "rust-demangler" change is sufficient in commit#321aebfa281. The PGO is reverted to it's default. Signed-off-by: Yash Shinde <Yash.Shinde@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io> (adapted from oe-core commit 83bd5e12e069a60a870a7c7ed046a2827eb777a1) Signed-off-by: Scott Murray <scott.murray@konsulko.com>
The rust profiler PGO (Profile-guided Optimization) options was disabled as a part rustdoc reproducibility fix. https://git.yoctoproject.org/poky/commit/meta/recipes-devtools/rust?id=321aebfa281bd28e368c684ece57867f6bd0cbe7 But, other applications (such as to build chromium with poky) requires PGO enabled (OSSystems/meta-browser#786). For reproducibility issue fix only "rust-demangler" change is sufficient in commit#321aebfa281. The PGO is reverted to it's default. (From OE-Core rev: 83bd5e12e069a60a870a7c7ed046a2827eb777a1) Signed-off-by: Yash Shinde <Yash.Shinde@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Hi,
I cannot seem to get this recipe to build with the new rust support
I use all the default flags of the recipe and follow master on all dependend layers.
I would like to know what I can do in order to get chromium to work again. :-)
I have taken out the snippet of the
do_compileoutput where it seems to break for some reason:The text was updated successfully, but these errors were encountered: