Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push Meter Class Changes to Prod #303

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Push Meter Class Changes to Prod #303

merged 1 commit into from
Feb 5, 2024

Conversation

solderq35
Copy link
Member

@solderq35 solderq35 commented Feb 5, 2024

basically this part of dependencies/nodejs/meter.js file bugs out if it can't find the meter class, and allBuildings API call calls all the meters connected to a meter group connected to a building, so that was why allBuildings API call was timing out on prod earlier today.

So I just move meter class changes from #302 into prod for now.

image

image

Another approach would be to buildings with "hidden" attribute from the allBuildings API call
(e.g. https://github.com/OSU-Sustainability-Office/energy-dashboard/blob/master/backend/dependencies/nodejs/models/building.js#L225), but I don't know if that would make it too difficult to test frontend of newly added buildings locally.

@solderq35 solderq35 merged commit 6c43ed2 into master Feb 5, 2024
3 checks passed
@s-egge s-egge deleted the meterclass-prod-fix branch July 1, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant