Added API to PluginKit so plugins can trigger hardware detection. #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godbyk
force-pushed
the
plugin-trigger-hardware-detect
branch
from
5fa83f0
to
2e4328a
Compare
|
Also needs rebasing by now (sorry) and possibly analysis/commenting of thread safety - may need lock guard in case it's called from an async plugin, etc. |
godbyk
force-pushed
the
plugin-trigger-hardware-detect
branch
from
2e4328a
to
84b3a12
Compare
|
I rebranched from master and applied this PR patch again so it should merge cleanly now. As for thread safety, I think we're okay there because we just set a trigger-hardware-detect flag to true (in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #155.