Using LateUpdate instead of Update #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PoseInterface, and PositionInterface to update the transform.
|
I think this is an improvement. At least, it should be... I am working on another branch with this change plus some other attempts at updating state later in execution order. Just would like to get some more eyes on this. See https://github.com/OSVR/OSVR-Unity/tree/enableCamera and #47 |
|
@DuFF14 so can I merge this or should I wait for your changes? |
|
@yboger and @mars979 tested this separately and both thought the Update() version felt better than LateUpdate(), at least on the HDK at Sensics (not sure which firmware this one is using). Hold off on merging this. Would like a consensus first. |
|
No longer applicable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DuFF14 suggested switching from Update to LateUpdate in OrientationInterface, PoseInterface, and PositionInterface as these unity events happen closer to when the frame is rendered.
cc: #61