Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of wave.do #35

Closed
wants to merge 3 commits into from
Closed

Conversation

riedel-ferringer
Copy link

This Pull Request combines three findings regarding wave.do and is a suggestion for resolving the issue(s). However, I am not fully aware of some of the implications (esp. removing the ReducePath procedure).

@JimLewis
Copy link
Member

JimLewis commented Nov 4, 2022

Markus,
I am not good enough at git to pull just the change for #33, so I will manually add that one.
I will also add a fix at the point where the paths are checked so wave.do is not done twice.

@JimLewis
Copy link
Member

JimLewis commented Nov 4, 2022

Please do your pull requests against the Dev branch rather than main. That way you will know about things I have already done - such as #29.

@JimLewis
Copy link
Member

JimLewis commented Nov 4, 2022

All of these are now fixed in dev. I did the file normalize where the paths are checked.

@JimLewis JimLewis closed this Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants