Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix redis-sentinel selector role value #164

Merged
merged 3 commits into from
Oct 16, 2023
Merged

fix redis-sentinel selector role value #164

merged 3 commits into from
Oct 16, 2023

Conversation

whzghb
Copy link
Contributor

@whzghb whzghb commented Oct 16, 2023

fix redis-sentinel selector role value

shubham-cmyk
shubham-cmyk requested changes Oct 16, 2023
View reviewed changes
Copy link
Member

@shubham-cmyk shubham-cmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you bump the version in the Chart.yaml

@whzghb
Copy link
Contributor Author

whzghb commented Oct 16, 2023

can you bump the version in the Chart.yaml

can you bump the version in the Chart.yaml

to 0.15.10?

@shubham-cmyk
Copy link
Member

shubham-cmyk commented Oct 16, 2023 •
edited
Loading

can you bump the version in the Chart.yaml

can you bump the version in the Chart.yaml

to 0.15.10?

yes but only for the sentinel>

Also it would be good if you sign off your commit.

@shubham-cmyk
Copy link
Member 

To add your Signed-off-by line to every commit in this branch:

Ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally).
In your local branch, run: git rebase HEAD~1 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin fix-redis-sentinel-selector-role-value

https://github.com/OT-CONTAINER-KIT/helm-charts/pull/164/checks?check_run_id=17724569386

@whzghb
fix redis-sentinel selector role value
f2165c6 
Signed-off-by: whzghb <631064936@qq.com>
@whzghb whzghb force-pushed the fix-redis-sentinel-selector-role-value branch from 729469f to f2165c6 Compare October 16, 2023 08:33
@whzghb
Copy link
Contributor Author

whzghb commented Oct 16, 2023

yes but only for the sentinel>

Also it would be good if you sign off your commit.

ok，i have resubmitted it

@shubham-cmyk
fix lints
381b81a 
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
@shubham-cmyk
fix linl-2
2a2edbe 
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
@shubham-cmyk shubham-cmyk merged commit b5a8eff into OT-CONTAINER-KIT:main Oct 16, 2023
5 checks passed
EStork09 pushed a commit to EStork09/helm-charts-ot that referenced this pull request Oct 18, 2023
@whzghb @shubham-cmyk @EStork09
fix redis-sentinel selector role value (OT-CONTAINER-KIT#164)
7cc7794 
* fix redis-sentinel selector role value

Signed-off-by: whzghb <631064936@qq.com>

* fix lints

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix linl-2

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: whzghb <631064936@qq.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: EStork09 <estork@live.com>
shubham-cmyk added a commit that referenced this pull request Oct 18, 2023
@EStork09 @whzghb @shubham-cmyk
Added name overwrite function to redis charts (#168)
cfe2734 
* fix redis-sentinel selector role value (#164)

* fix redis-sentinel selector role value

Signed-off-by: whzghb <631064936@qq.com>

* fix lints

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix linl-2

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: whzghb <631064936@qq.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: EStork09 <estork@live.com>

* Added name overwrite function to redis charts

Signed-off-by: EStork09 <estork@live.com>

* Bumpped versions

Signed-off-by: EStork09 <estork@live.com>

* Moved fields for name under specific configuration

Signed-off-by: EStork09 <estork@live.com>

* Adjusted values.yaml to address linting report

Signed-off-by: EStork09 <estork@live.com>

* Addressed linting errors

Signed-off-by: EStork09 <estork@live.com>

---------

Signed-off-by: whzghb <631064936@qq.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: EStork09 <estork@live.com>
Co-authored-by: whzghb <41436057+whzghb@users.noreply.github.com>
Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
mrhovunping pushed a commit to mrhovunping/bug-165 that referenced this pull request Nov 28, 2023
@whzghb @shubham-cmyk @sho34215
fix redis-sentinel selector role value (OT-CONTAINER-KIT#164)
ba4ca84 
* fix redis-sentinel selector role value

Signed-off-by: whzghb <631064936@qq.com>

* fix lints

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix linl-2

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: whzghb <631064936@qq.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Sébastien HO <sho@smartadserver.com>
mrhovunping pushed a commit to mrhovunping/bug-165 that referenced this pull request Nov 28, 2023
@EStork09 @whzghb
@shubham-cmyk @sho34215
Added name overwrite function to redis charts (OT-CONTAINER-KIT#168)
452b2c9 
* fix redis-sentinel selector role value (OT-CONTAINER-KIT#164)

* fix redis-sentinel selector role value

Signed-off-by: whzghb <631064936@qq.com>

* fix lints

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix linl-2

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: whzghb <631064936@qq.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: EStork09 <estork@live.com>

* Added name overwrite function to redis charts

Signed-off-by: EStork09 <estork@live.com>

* Bumpped versions

Signed-off-by: EStork09 <estork@live.com>

* Moved fields for name under specific configuration

Signed-off-by: EStork09 <estork@live.com>

* Adjusted values.yaml to address linting report

Signed-off-by: EStork09 <estork@live.com>

* Addressed linting errors

Signed-off-by: EStork09 <estork@live.com>

---------

Signed-off-by: whzghb <631064936@qq.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: EStork09 <estork@live.com>
Co-authored-by: whzghb <41436057+whzghb@users.noreply.github.com>
Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Sébastien HO <sho@smartadserver.com>
mrhovunping pushed a commit to mrhovunping/bug-165 that referenced this pull request Nov 28, 2023
@whzghb @shubham-cmyk @sho34215
fix redis-sentinel selector role value (OT-CONTAINER-KIT#164)
3d45157 
* fix redis-sentinel selector role value

Signed-off-by: whzghb <631064936@qq.com>

* fix lints

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix linl-2

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: whzghb <631064936@qq.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Sébastien HO <sho@smartadserver.com>
mrhovunping pushed a commit to mrhovunping/bug-165 that referenced this pull request Nov 28, 2023
@EStork09 @whzghb
@shubham-cmyk @sho34215
Added name overwrite function to redis charts (OT-CONTAINER-KIT#168)
d3e5ba3 
* fix redis-sentinel selector role value (OT-CONTAINER-KIT#164)

* fix redis-sentinel selector role value

Signed-off-by: whzghb <631064936@qq.com>

* fix lints

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix linl-2

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: whzghb <631064936@qq.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: EStork09 <estork@live.com>

* Added name overwrite function to redis charts

Signed-off-by: EStork09 <estork@live.com>

* Bumpped versions

Signed-off-by: EStork09 <estork@live.com>

* Moved fields for name under specific configuration

Signed-off-by: EStork09 <estork@live.com>

* Adjusted values.yaml to address linting report

Signed-off-by: EStork09 <estork@live.com>

* Addressed linting errors

Signed-off-by: EStork09 <estork@live.com>

---------

Signed-off-by: whzghb <631064936@qq.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: EStork09 <estork@live.com>
Co-authored-by: whzghb <41436057+whzghb@users.noreply.github.com>
Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Sébastien HO <sho@smartadserver.com>
mrhovunping pushed a commit to mrhovunping/bug-165 that referenced this pull request Nov 28, 2023
@whzghb @shubham-cmyk @sho34215
fix redis-sentinel selector role value (OT-CONTAINER-KIT#164)
4855802 
* fix redis-sentinel selector role value

Signed-off-by: whzghb <631064936@qq.com>

* fix lints

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix linl-2

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: whzghb <631064936@qq.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Sébastien HO <sho@smartadserver.com>
mrhovunping pushed a commit to mrhovunping/bug-165 that referenced this pull request Nov 28, 2023
@EStork09 @whzghb
@shubham-cmyk @sho34215
Added name overwrite function to redis charts (OT-CONTAINER-KIT#168)
c3055ff 
* fix redis-sentinel selector role value (OT-CONTAINER-KIT#164)

* fix redis-sentinel selector role value

Signed-off-by: whzghb <631064936@qq.com>

* fix lints

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix linl-2

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: whzghb <631064936@qq.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: EStork09 <estork@live.com>

* Added name overwrite function to redis charts

Signed-off-by: EStork09 <estork@live.com>

* Bumpped versions

Signed-off-by: EStork09 <estork@live.com>

* Moved fields for name under specific configuration

Signed-off-by: EStork09 <estork@live.com>

* Adjusted values.yaml to address linting report

Signed-off-by: EStork09 <estork@live.com>

* Addressed linting errors

Signed-off-by: EStork09 <estork@live.com>

---------

Signed-off-by: whzghb <631064936@qq.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: EStork09 <estork@live.com>
Co-authored-by: whzghb <41436057+whzghb@users.noreply.github.com>
Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Sébastien HO <sho@smartadserver.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubham-cmyk shubham-cmyk shubham-cmyk requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@whzghb @shubham-cmyk