Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exporter ports enabled even when exporters disabled #484

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

sadath-12
Copy link
Contributor

fix #474

Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
@shubham-cmyk
Copy link
Member

LGTM!

@shubham-cmyk shubham-cmyk merged commit b2ee925 into OT-CONTAINER-KIT:master Apr 7, 2023
16 checks passed
jiuker pushed a commit to jiuker/redis-operator-1 that referenced this pull request Jul 20, 2023
…R-KIT#484)

* fix: exporter ports enabled even when exporters disabled

Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>

* fix: dependency issues

Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>

---------

Signed-off-by: sadath-12 <sadathsadu2002@gmail.com>
Signed-off-by: guozhi.li <guozhi.li@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redis service still exposes exporter port after disabling exporter
2 participants