[Feature] : Adding Custom TerminationGracePeriodSeconds and additional fields for Sidecar #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com>
Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com>
Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com>
|
@Sasidharan3094 Why this PR delete initContainer. |
|
@shubham-cmyk My bad, I think I didn't rebase properly. Let me fix it and revert. |
Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com>
|
@shubham-cmyk Please check now. |
shubham-cmyk
changed the title
jiuker
pushed a commit
to jiuker/redis-operator-1
that referenced
this pull request
Jul 20, 2023
…dSeconds (OT-CONTAINER-KIT#487) * initial commit Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com> * updating Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com> * + Sidecar features & termgraceperiodsecs Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com> * generating manager Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com> * PR Comments Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com> --------- Signed-off-by: Sasidharan-3094 <sasidharan.gopal94@gmail.com> Co-authored-by: Sasidharan Gopal <sasidharan.gopal@freshworks.com> Signed-off-by: guozhi.li <guozhi.li@daocloud.io>
jiuker
pushed a commit
to jiuker/redis-operator-1
that referenced
this pull request
Jul 20, 2023
…acePeriodSeconds (OT-CONTAINER-KIT#487)" (OT-CONTAINER-KIT#492) This reverts commit 559f40a. Signed-off-by: guozhi.li <guozhi.li@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the below additional features for Sidecar which would be good to have them.
Added TerminationGracePeriodSeconds for RedisLeader and RedisFollower, Default is 30 seconds but it would be good to have buffer time for graceful shutdown, especially for production-grade workloads.
Type of change
Checklist