Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add watchnamespace function #520

Merged
merged 2 commits into from
Jun 15, 2023
Merged

add watchnamespace function #520

merged 2 commits into from
Jun 15, 2023

Conversation

progmatv
Copy link
Contributor

This PR add watchnamespace function. To activate it add to manager.yaml in section containers:

         env:
          - name: WATCH_NAMESPACE
            valueFrom:
              fieldRef:
                fieldPath: metadata.namespace

@shubham-cmyk
Copy link
Member

shubham-cmyk commented Jun 13, 2023 •
edited

I don't think there is a need for this PR.
Since it is already included in the code.

image

But I think we can add this option in the helm chart.

@progmatv
Copy link
Contributor Author

We have an issue when use Operator Lifecycle Manager with current configuration. watchnamespace function needs for enable Namespace scoped operators. Here's link https://sdk.operatorframework.io/docs/building-operators/golang/operator-scope/#configuring-namespace-scoped-operators

@shubham-cmyk
Copy link
Member

This option is already included in the code.
https://github.com/OT-CONTAINER-KIT/redis-operator/blob/master/main.go#L77

@progmatv
Copy link
Contributor Author

OLM requires watchNamespace as a variable name

@shubham-cmyk
Copy link
Member

can we change the name of the env-variable here ?

@progmatv
Copy link
Contributor Author

yes this can work

@shubham-cmyk shubham-cmyk reopened this Jun 15, 2023
@shubham-cmyk
change Env Variable Name
e4ddbbb 
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
@shubham-cmyk shubham-cmyk merged commit 21d4f85 into OT-CONTAINER-KIT:master Jun 15, 2023
16 checks passed
shubham-cmyk added a commit to shubham-cmyk/redis-operator that referenced this pull request Jun 30, 2023
@progmatv @shubham-cmyk
add watchnamespace function (OT-CONTAINER-KIT#520)
e8bb2cd 
* add watchnamespace function

* change Env Variable Name

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
shubham-cmyk added a commit to shubham-cmyk/redis-operator that referenced this pull request Jun 30, 2023
@shubham-cmyk
Revert "add watchnamespace function (OT-CONTAINER-KIT#520)"
cbc9cfc 
This reverts commit e8bb2cd.
shubham-cmyk added a commit that referenced this pull request Jul 1, 2023
@shubham-cmyk @progmatv
Feature: Support Scaling for Redis Cluster (#531)
2f8f34e 
* Set up CI with Azure Pipelines

[skip ci]

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* Update pipeline.yaml

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* Fix Bug : Operator Crash when persistence is false (#519)

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* add watchnamespace function (#520)

* add watchnamespace function

* change Env Variable Name

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix the loop call of checkAttachedSlave (#523)

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* Redis Cluster Scaling

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* revert the pipeline

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* comment some funcs

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* remove Commented code

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* Set up CI with Azure Pipelines

[skip ci]

* Update pipeline.yaml

* Revert "fix the loop call of checkAttachedSlave (#523)"

This reverts commit 6713dbc.

* Revert "add watchnamespace function (#520)"

This reverts commit e8bb2cd.

* Revert "Fix Bug : Operator Crash when persistence is false (#519)"

This reverts commit faa45b5.

* Revert "Update pipeline.yaml"

This reverts commit db717f5.

* update pipeline

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Co-authored-by: progmatv <60739920+progmatv@users.noreply.github.com>
jiuker pushed a commit to jiuker/redis-operator-1 that referenced this pull request Jul 20, 2023
@progmatv @shubham-cmyk
add watchnamespace function (OT-CONTAINER-KIT#520)
7d4100c 
* add watchnamespace function

* change Env Variable Name

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: guozhi.li <guozhi.li@daocloud.io>
jiuker pushed a commit to jiuker/redis-operator-1 that referenced this pull request Jul 20, 2023
@shubham-cmyk @progmatv
Feature: Support Scaling for Redis Cluster (OT-CONTAINER-KIT#531)
1dcbc57 
* Set up CI with Azure Pipelines

[skip ci]

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* Update pipeline.yaml

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* Fix Bug : Operator Crash when persistence is false (OT-CONTAINER-KIT#519)

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* add watchnamespace function (OT-CONTAINER-KIT#520)

* add watchnamespace function

* change Env Variable Name

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Co-authored-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* fix the loop call of checkAttachedSlave (OT-CONTAINER-KIT#523)

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* Redis Cluster Scaling

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* revert the pipeline

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* comment some funcs

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* remove Commented code

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

* Set up CI with Azure Pipelines

[skip ci]

* Update pipeline.yaml

* Revert "fix the loop call of checkAttachedSlave (OT-CONTAINER-KIT#523)"

This reverts commit 6713dbc.

* Revert "add watchnamespace function (OT-CONTAINER-KIT#520)"

This reverts commit e8bb2cd.

* Revert "Fix Bug : Operator Crash when persistence is false (OT-CONTAINER-KIT#519)"

This reverts commit faa45b5.

* Revert "Update pipeline.yaml"

This reverts commit db717f5.

* update pipeline

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

---------

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Co-authored-by: progmatv <60739920+progmatv@users.noreply.github.com>
Signed-off-by: guozhi.li <guozhi.li@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@progmatv @shubham-cmyk