Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] : redis data pvc not deleted #703

Merged
merged 5 commits into from
Nov 14, 2023

Conversation

drivebyer
Copy link
Collaborator

@drivebyer drivebyer commented Nov 14, 2023

part of : #656

Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
@drivebyer drivebyer added the bug Something isn't working label Nov 14, 2023
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (697538e) 27.90% compared to head (bdbe6f0) 27.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #703   +/-   ##
=======================================
  Coverage   27.90%   27.90%           
=======================================
  Files          18       18           
  Lines        3111     3111           
=======================================
  Hits          868      868           
  Misses       2216     2216           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@shubham-cmyk shubham-cmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drivebyer drivebyer merged commit 6502c91 into OT-CONTAINER-KIT:master Nov 14, 2023
20 checks passed
@drivebyer drivebyer deleted the fix-pvc branch November 14, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants