Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support create redis cluster by nodeport service #738

Merged
merged 12 commits into from
Dec 27, 2023

Conversation

drivebyer
Copy link
Collaborator

@drivebyer drivebyer commented Dec 27, 2023

Description

#183

PS:

It works only from redis 6 now. When use redis:latest image(7.2.3 for now), the redis-cli --cluster create will hang forever. Maybe there is some break change introduce in redis 7

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

Signed-off-by: drivebyer <yang.wu@daocloud.io>
Signed-off-by: drivebyer <yang.wu@daocloud.io>
Signed-off-by: drivebyer <yang.wu@daocloud.io>
Signed-off-by: drivebyer <yang.wu@daocloud.io>
Signed-off-by: drivebyer <yang.wu@daocloud.io>
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 94 lines in your changes are missing coverage. Please review.

Comparison is base (deefc14) 29.43% compared to head (b0001cb) 28.75%.
Report is 2 commits behind head on master.

Files Patch % Lines
k8sutils/redis-cluster.go 2.53% 76 Missing and 1 partial ⚠️
controllers/rediscluster_controller.go 0.00% 8 Missing ⚠️
k8sutils/services.go 16.66% 4 Missing and 1 partial ⚠️
k8sutils/statefulset.go 63.63% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #738      +/-   ##
==========================================
- Coverage   29.43%   28.75%   -0.68%     
==========================================
  Files          19       19              
  Lines        3170     3269      +99     
==========================================
+ Hits          933      940       +7     
- Misses       2207     2295      +88     
- Partials       30       34       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: drivebyer <yang.wu@daocloud.io>
Signed-off-by: drivebyer <yang.wu@daocloud.io>
Signed-off-by: drivebyer <yang.wu@daocloud.io>
Signed-off-by: drivebyer <yang.wu@daocloud.io>
Signed-off-by: drivebyer <yang.wu@daocloud.io>
Signed-off-by: drivebyer <yang.wu@daocloud.io>
@drivebyer drivebyer enabled auto-merge (squash) December 27, 2023 11:09
@drivebyer drivebyer added the enhancement New feature or request label Dec 27, 2023
Signed-off-by: drivebyer <wuyangmuc@gmail.com>
Copy link
Member

@shubham-cmyk shubham-cmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drivebyer drivebyer merged commit c8fd3bd into OT-CONTAINER-KIT:master Dec 27, 2023
26 of 28 checks passed
@drivebyer drivebyer deleted the node-port branch December 28, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants