ci: Improve CI linting #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #791 +/- ##
==========================================
+ Coverage 32.69% 32.76% +0.06%
==========================================
Files 19 19
Lines 3233 3220 -13
==========================================
- Hits 1057 1055 -2
+ Misses 2116 2106 -10
+ Partials 60 59 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
shubham-cmyk
force-pushed
the
golang-ci-lint
branch
from
b821a30
to
4a9b1ae
Compare
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
wkd-woo
pushed a commit
to wkd-woo/redis-operator
that referenced
this pull request
Mar 4, 2024
* ci: enable more linters Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * ci: diable few checks for temporary Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * ci: read permission to ci Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * ci: try removing cache Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * ci: diable ifelse linter for temp Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * syle: run gofumpt Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * sytle: run gci Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * ci: prevent misspell Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * ci: run go import Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * style: fix style errors Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * style: fix trailing lines Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * remove unwanted conversion Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * remove gci from generated file Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * style: remove init check Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * fix: type conversion Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * fix: remove context Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * ci: update configuration file Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * ci: skip generated files Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * ci: remove disabled lintesr Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> --------- Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> Signed-off-by: wkd-woo <wkdwoos@gmail.com>
wkd-woo
pushed a commit
to wkd-woo/redis-operator
that referenced
this pull request
Mar 4, 2024
* ci: enable more linters Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * ci: diable few checks for temporary Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * ci: read permission to ci Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * ci: try removing cache Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * ci: diable ifelse linter for temp Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * syle: run gofumpt Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * sytle: run gci Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * ci: prevent misspell Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * ci: run go import Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * style: fix style errors Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * style: fix trailing lines Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * remove unwanted conversion Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * remove gci from generated file Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * style: remove init check Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * fix: type conversion Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * fix: remove context Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * ci: update configuration file Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * ci: skip generated files Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> * ci: remove disabled lintesr Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> --------- Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> Signed-off-by: wkd-woo <wkdwoos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #790
Type of change
Improve the CI practice in the Operator
Checklist