ci: fmt and vet covered in golang Ci linters by default #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #792 +/- ##
==========================================
- Coverage 32.78% 32.69% -0.10%
==========================================
Files 19 19
Lines 3233 3233
==========================================
- Hits 1060 1057 -3
- Misses 2114 2116 +2
- Partials 59 60 +1 ☔ View full report in Codecov by Sentry. |
shubham-cmyk
had a problem deploying
to
release-image
GitHub Actions
Failure
wkd-woo
pushed a commit
to wkd-woo/redis-operator
that referenced
this pull request
Mar 4, 2024
…-KIT#792) Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> Signed-off-by: wkd-woo <wkdwoos@gmail.com>
wkd-woo
pushed a commit
to wkd-woo/redis-operator
that referenced
this pull request
Mar 4, 2024
…-KIT#792) Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com> Signed-off-by: wkd-woo <wkdwoos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the fmt and vet Ci check since they are already covered in the golang CI linters that we are using