Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use redis client library #840

Merged
merged 3 commits into from
Mar 24, 2024

Conversation

shubham-cmyk
Copy link
Member

No description provided.

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 35.94%. Comparing base (17b9d2c) to head (a6c48c0).
Report is 22 commits behind head on master.

Files Patch % Lines
k8sutils/cluster-scaling.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #840      +/-   ##
==========================================
+ Coverage   35.20%   35.94%   +0.74%     
==========================================
  Files          19       19              
  Lines        3213     2612     -601     
==========================================
- Hits         1131      939     -192     
+ Misses       2015     1605     -410     
- Partials       67       68       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>
@shubham-cmyk shubham-cmyk changed the title chore: use appropriate way to calulate slots chore: use redis client library Mar 23, 2024
@shubham-cmyk shubham-cmyk enabled auto-merge (squash) March 23, 2024 18:09
@shubham-cmyk
Copy link
Member Author

@drivebyer
Can you approve this

@shubham-cmyk shubham-cmyk merged commit ff91665 into OT-CONTAINER-KIT:master Mar 24, 2024
28 of 29 checks passed
@shubham-cmyk shubham-cmyk deleted the cluster-slots branch March 24, 2024 06:12
@drivebyer
Copy link
Collaborator

Great! This is a more elegant way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants