Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x-mitre-data-component #37

Merged
merged 2 commits into from Jan 6, 2022
Merged

Add x-mitre-data-component #37

merged 2 commits into from Jan 6, 2022

Conversation

ZikyHD
Copy link

@ZikyHD ZikyHD commented Oct 31, 2021

Add :

  • data_component_stix_mapping
  • get_enterprise_data_components()
  • get_data_components() (maybe in the future)
  • get_techniques_detected_by_all_data_components()
  • get_techniques_detected_by_data_component()
  • get_data_component_by_technique()

@Cyb3rWard0g
Copy link
Collaborator

Once again @ZikyHD ! Thank you very much for taking the time to do this! It looks good to me just by going through the code. I have to test your branch on my dev vm. I will be doing that on Friday this week. I will merge after that.

Thank you again! 🍻

@ZikyHD
Copy link
Author

ZikyHD commented Nov 17, 2021

@Cyb3rWard0g any update on my proposal ? 😅

@Cyb3rPandaH
Copy link
Collaborator

Hey @ZikyHD , hope everything is going well.

Sorry for the late reply, @Cyb3rWard0g and I are reviewing the PR. We will merge it over the weekend 👍

Thank you again for your contribution guys 🙏

@Cyb3rPandaH
Copy link
Collaborator

Quick question @ZikyHD

What is the idea behind the function get_techniques_detected_by_all_data_components (Line 1479). Is it to get all techniques that have data components?

Thanks,

Jose

Copy link
Collaborator

@Cyb3rWard0g Cyb3rWard0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ZikyHD ! Thank you again! @Cyb3rPandaH and I are working on it at the moment. These two functions are missing. I was wondering if maybe the code was not committed as part of the PR or maybe data components do not exist yet in ICS and mobile data. We are going to check that out that too right now.

attackcti/attack_api.py Show resolved Hide resolved
attackcti/attack_api.py Show resolved Hide resolved
@Cyb3rWard0g
Copy link
Collaborator

Thank you @ZikyHD ! I will accept the PR and comment out the functions that do not retrieve data components from Mobile and ICS inside of get_data_components().

Thank you again for the contribution and your patience! We really appreciate it!

@Cyb3rWard0g Cyb3rWard0g merged commit f32c9a4 into OTRF:master Jan 6, 2022
@ZikyHD ZikyHD deleted the attack10_additions branch January 23, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants