added include_pre_attack parameter to attack_client constructor #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much @rubinatorz ! I appreciate you taking the time to share the fix. I will upgrade the library package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Cyb3rWard0g,
As described in #59 I would propose for having a parameter in de attack_client constructor to not include pre-attack STIX objects in the COMPOSITE_DS variable, because it will include information on PRE while this information is not updated by MITRE anymore. The parameter is called include_pre_attack, which is an optional parameter having False as default value. People can still choose to include pre-attack objects by setting include_pre_attack=True in the constructor.
I saw the get_pre_xxx methods and I made it in a way that with this new parameter set to False this get_pre_xxx methods will still work (because TC_PRE_SOURCE is still populated (but not included in COMPOSITE_DS).