Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ICS campaigns and some ICS fixes #64

Merged
merged 2 commits into from Apr 13, 2023
Merged

Conversation

rubinatorz
Copy link
Contributor

hi @Cyb3rWard0g!

I have added ICS campaigns and complemented the ics_filter_objects with items that were "missing". I know ICS doesn't have tools, but maybe in the future :) And I fixed some typos.

Regards,
Ruben

Copy link
Collaborator

@Cyb3rWard0g Cyb3rWard0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niceee!! Thank you @rubinatorz ! :)

Copy link
Collaborator

@Cyb3rWard0g Cyb3rWard0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thank you for taking the time @rubinatorz !

@Cyb3rWard0g
Copy link
Collaborator

Hello @rubinatorz ! it has been a while since we last spoke. Thank you for taking the time to contribute to the library I will release a new version of the library today

@Cyb3rWard0g Cyb3rWard0g merged commit 84dd996 into OTRF:master Apr 13, 2023
@Cyb3rWard0g
Copy link
Collaborator

@rubinatorz
Copy link
Contributor Author

Thanks a lot @Cyb3rWard0g!

I think you can close PR #63 (from someone else), because I noticed that his small change was included in my PR as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants