Fix a bug where all groups/campaigns are returned from case insensitive search of get_group_by_alias/get_campaign_by_alias
#80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelok
changed the title
|
Upon further looking at the code... this particular bug exists in other spots as well. |
thelok
changed the title
get_group_by_alias/get_campaign_by_alias
thelok
changed the title
get_group_by_alias/get_campaign_by_aliasget_group_by_alias/get_campaign_by_alias
|
Nice catch!! Thank you for all the contributions @thelok !! |
Cyb3rWard0g
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug is caused by the local variable
aliasclashing with the method parameter name (alsoalias) when performing a case insensitive search ofget_group_by_alias/get_campaign_by_aliasIn the 0.4.0 release I would get 1 result from the
get_group_by_aliascall but then I end up getting 400+ results in 0.4.1