Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work in progress 1.8.33 (PHP7) #42

Merged
merged 30 commits into from
Nov 26, 2023
Merged

Work in progress 1.8.33 (PHP7) #42

merged 30 commits into from
Nov 26, 2023

Conversation

Sama34
Copy link
Collaborator

@Sama34 Sama34 commented May 29, 2023

The following is a limited list of the changes in this release.

  • Minimum MyBB requirement bumped up to 1.8.30
  • Minimum PHP requirement bumped up to 8.2
  • Update required for MySQL 8 (not minimum requirement).
  • Update to the plugin files structure.
  • Select the priority for appending categories to the UserCP menu.
  • initialize PHP files on global end (default), global intermediate, global start, or at plugin execution time ("init").
  • Build a menu for each category to link to pages in the header.
  • Use a theme template instead for each page's content.
  • Add a navigation (previous/next) to categories.
  • Add a "last edited on" message to all pages.
  • Update example pages for PHP and MyBB versions.
  • Add file setting to block the usage of eval()

Use templates for the ACP
Also simplifies the logic for loading pages as it was overcomplicated
- Complete navigation (previous/next) feature
- Remove legacy code
- Rework Database migration
- Reduces query calls on favor of the cache system
- Canonical URL addition and attempt to enforce unified URL
- Delete category's pages when deleting it
@Eldenroot
Copy link
Contributor

Php should be 7.2 and up... many users cannot use higher version (webhosting, other plugins, mybb core)

- Add helper for core cache rebuild
- Update `allowedGroups` from empty to -1 when updating from legacy version
- Rebuild cache on plugin activation
- Add required mark back
@Sama34 Sama34 changed the title Work in progress 1.8.33 (PHP8) Work in progress 1.8.33 (PHP7) May 30, 2023
@Sama34
Copy link
Collaborator Author

Sama34 commented May 30, 2023

Php should be 7.2 and up... many users cannot use higher version (webhosting, other plugins, mybb core)

I just downgraded the PHP version down to 7.4, you can check the develop branch.

According to the IDE there are no errors for 7.2 but I don't have an environment to test, if you can confirm it works in 7.2 I could consider supporting it.

Sama34 added 17 commits May 31, 2023 01:25
- Update example pages to sync with documentation
- Update language strings to sync with documentation
- Remove echoing at `initExecute()`
- Update init EXECUTION_HOOK_GLOBAL_END logic
- Update hooks to sync with documentation
- Remove hardcoded HTML for link building
- Fix hooks handling
- Fix getSetting()
* Update documentation

* Add friendly urls information

- Describe category and page form fields

* Update emojis

Remove leftovers

* Fix grammar and links

* Fix small buggies

* Update documentation to sync with develop

* Document link building templates (front-end)
Additionally fix some identical comparison operations
Replace potential invalid key
Used by the Sticky Threads sample page
Update folder structure references
@Sama34 Sama34 merged commit b7c96b1 into master Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants