Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken filter link when using friendly urls #15

Open
Sama34 opened this issue Jun 13, 2023 · 1 comment
Open

Broken filter link when using friendly urls #15

Sama34 opened this issue Jun 13, 2023 · 1 comment
Labels
b:main Branch: main or affecting released codebase p:low Priority: Low. Issue to resolve with low preference s:confirmed Status: Confirmed. Retested and found the issue exists t:bug Type: Bug. An issue causing error / flaw / malfunction

Comments

@Sama34
Copy link
Collaborator

Sama34 commented Jun 13, 2023 •
edited

Describe the bug
When the forum is set to use friendly urls, the filtering link for posts appends the thread action to the generated thread link. This is only necessary when using the core friendly urls feature.

To Reproduce

  1. Enable the code friendly urls feature.
  2. Enable the post filter experimental feature. [Feature request] Show user's posts in the thread #7
  3. Go to any thread and click into a contributor username or avatar to filter the thread posts.
  4. See error

Expected behavior
If friendly urls are enabled, the generated link should not append any action to the generated thread link.

Additional context
Default dynamic urls and Google SEO (plugin) are not affected.
@Sama34 Sama34 added b:main Branch: main or affecting released codebase s:confirmed Status: Confirmed. Retested and found the issue exists p:low Priority: Low. Issue to resolve with low preference t:bug Type: Bug. An issue causing error / flaw / malfunction labels Jun 13, 2023
Sama34 added a commit that referenced this issue Jun 13, 2023
@Sama34
Fix #15 Broken filter link when using friendly urls
f5b93e4 
Check if `$mybb->seo_support` is true for appending the `thread` action to the  generated thread link.
@Eldenroot
Copy link

@Sama34 - yes, the fix 15 is working fine! You can merge it! Thank you!

@Sama34 Sama34 mentioned this issue Jun 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
b:main Branch: main or affecting released codebase p:low Priority: Low. Issue to resolve with low preference s:confirmed Status: Confirmed. Retested and found the issue exists t:bug Type: Bug. An issue causing error / flaw / malfunction
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Eldenroot @Sama34