Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change CAS login verbiage #12

Merged
merged 20 commits into from Apr 5, 2017
Merged

Conversation

groundedgopher
Copy link
Contributor

No description provided.

@@ -14,8 +14,8 @@ ssl_cert_path: /etc/pki/tls/certs
ssl_key_path: /etc/pki/tls/private

# UI
cas_screen_welcome_instructions: Enter your Username and Password
cas_screen_welcome_security: For security reasons, please Log Out and Exit your web browser when you are done accessing services that require authentication!
cas_screen_welcome_instructions: Login with your OUNetID (4x4)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to change the default values. These message defaults are set to the cas out of the box defaults. We can just set the values appropriately in production. If you have bits of text you want to set, define a var with the original value here, and then we'll set the vars on deploy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have set the variables in vagrant infrastructure in the host_vars now. In place of the hard coded version is the original default values.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a pull request for these changes in vagrant_infrastructure also

@@ -22,7 +22,7 @@
screen.welcome.welcome=Congratulations on bringing CAS online! To learn how to authenticate, please review the default authentication handler configuration.
screen.welcome.security={{ cas_screen_welcome_security }}
screen.welcome.instructions={{ cas_screen_welcome_instructions }}
screen.welcome.label.netid=<span class="accesskey">U</span>sername:
screen.welcome.label.netid=<span class="accesskey">O</span>UNetID (4x4):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't hardcode values here, create a var that gets templated in, like cas_screen_welcome_instructions. Note the naming convention of vars.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now a variable {{ cas_screen_label_netid }}. It is also in the main.yml file in vagrant_infrastructure

Copy link
Contributor

@jsnshrmn jsnshrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, will need to resolve merge conflicts, but that's not your problem.

@jsnshrmn jsnshrmn merged commit c66e0bb into OULibraries:master Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants