Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack Optimization and Null Check Error Fix #203

Merged
merged 3 commits into from
Mar 5, 2023

Conversation

solo-daemon
Copy link
Contributor

fix #202 fix #173

@solo-daemon
Copy link
Contributor Author

solo-daemon commented Mar 3, 2023

@fredfalcon @just-ary27

So the current stack management has one flaw :

When we leave the home page to the profile page it adds the profile page over homepage in the widget tree and when we log out from profile page we replace that with the welcome page so in between the home page was left so when you go back from this welcome it gives you a screen given null check error as in #173 . also this elemenet keeps building up in the widget tree continuosly as more and more such actions are performed .

And hence it also automatically solve #173 along with improving stack management .

@solo-daemon
Copy link
Contributor Author

Also on moving to the the home page I think we should remove the welcome page from stack . I am thinking of a way it is possible . very easily .

@solo-daemon
Copy link
Contributor Author

So right now should i change my pr to be storing the welcome on moving to home page or should leave it as is?

@solo-daemon
Copy link
Contributor Author

This pr is now ready for review .

@fredfalcon fredfalcon added this pull request to the merge queue Mar 5, 2023
@justary27
Copy link
Collaborator

@solo-daemon I would suggest you to add a video showing the work you added from next time.

Merged via the queue into OWASP-BLT:main with commit 5f5bf75 Mar 5, 2023
DonnieBLT pushed a commit that referenced this pull request Aug 12, 2023
Co-authored-by: Fred Falcon <7475382+fredfalcon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants