Remove all instances of the last app name, changed to BLT #215
Conversation
Co-authored-by: Fred Falcon <7475382+fredfalcon@users.noreply.github.com>
Co-authored-by: Fred Falcon <7475382+fredfalcon@users.noreply.github.com>
|
All the icons can stay the same and we can remove the old white bugheist logo |
Same as this PR or same as the original repo? Do you want to keep this |
ios/Runner/Info.plist
Outdated
| @@ -43,25 +45,9 @@ | |||
| </array> | |||
| <key>UIViewControllerBasedStatusBarAppearance</key> | |||
| <false/> | |||
| <key>CFBundleURLTypes</key> | |||
There was a problem hiding this comment.
Can keep these the app needs permission to the files and also accepts a sharing intent from the share sheet
There was a problem hiding this comment.
Actually the ios/ folder had so many bugheist references in autogenerated files. So I had the entire folder rebuilt after changing bugheist to blt, maybe that is why we lost the changes which were made manually.
There was a problem hiding this comment.
Ok I will fix the CI tomorrow and test it out - thanks so much
There was a problem hiding this comment.
Can you please add the lines back? Looks like they didn’t revert
There was a problem hiding this comment.
Can you please add the lines back? Looks like they didn’t revert
I think they did revert - https://github.com/letsintegreat/Flutter/blob/change-name-blt/ios/Runner/Info.plist#L48
There was a problem hiding this comment.
Use the new logo - and keep the app icons they only show the red symbol and no name so they can remain the same. Only change the logos |
App icons are not changed in this PR, only the logos were updated. |
It looks like they got replaced with flutter icons |
ios/Runner/Info.plist
Outdated
| @@ -43,25 +45,9 @@ | |||
| </array> | |||
| <key>UIViewControllerBasedStatusBarAppearance</key> | |||
| <false/> | |||
| <key>CFBundleURLTypes</key> | |||
There was a problem hiding this comment.
Can you please add the lines back? Looks like they didn’t revert
|
Looks good to me - @just-ary27 can you please take a look? |
There was a problem hiding this comment.
LGTM - merging to main and if there are any issues or feedback from @just-ary27 we can update in a new PR. Thanks @letsintegreat
* Remove all instances of the last app name, changed to BLT * remove redundant file * Update .github/workflows/issue-assign.yml Co-authored-by: Fred Falcon <7475382+fredfalcon@users.noreply.github.com> * Update CONTRIBUTING.md Co-authored-by: Fred Falcon <7475382+fredfalcon@users.noreply.github.com> * revert deleted icons * Update about constants * refactor link * refactor all links * One baseUrl across all endpoint files * fix a url * revert a change in Info.plist * remove old logos again * revert ios icons * revert web folder * fix base url * update screenshots * update screenshot * revert changes in Info.plist * replace info.plist with the original file to fix indentation --------- Co-authored-by: Fred Falcon <7475382+fredfalcon@users.noreply.github.com>
Closes #214